hreview-creator-issues

(Difference between revisions)

Jump to: navigation, search
m (Reverted edits by AllirIcpas (Talk) to last version by Tantek)
(Added javascript bug report with suggested patch)
Line 7: Line 7:
== Bug Reports ==
== Bug Reports ==
 +
* In Firefox 3.0.10, Opera 9.64 build 5270 if there is an entry in both the description and rating fields the source of the function "rating_stars" is returned rather than the value of evaluating it. A quick fix would be to update line 153 of hreview.html from:
 +
 +
<pre>appendChildNodes(description_element, P({}, ABBR({'title' : rating, 'class' : 'rating'}, unescape(rating_stars)), ' ', escape_output(paras[0]))); </pre>
 +
 +
to
 +
 +
<pre>appendChildNodes(description_element, P({}, ABBR({'title' : rating, 'class' : 'rating'}, unescape(rating_stars(rating))), ' ', escape_output(paras[0]))); </pre>
 +
 +
The hReview creator doesn't work with IE6 (unknown version) on XP, IE7 (unknown version) on Vista or Safari (3.2.1 (5525.27.1)) on OS X. The "Code", "Compact Code" and "Preview" areas of the page are never updated. Not sure why due to the rather opaque javascript error messages in IE and Safari.
* word "date*" in "review date*" jumps on the next row and moves "reviewer*" down in Safari (var. 2.0.4 (419.3)). It looks like "review" is label for date, "date*" is label for text field and "reviewer*" is label for empty row. The same bug in the latest WebKit. ''reported by Dmitry Baranovskiy at 2006-07-20'' (link to mail archives?)
* word "date*" in "review date*" jumps on the next row and moves "reviewer*" down in Safari (var. 2.0.4 (419.3)). It looks like "review" is label for date, "date*" is label for text field and "reviewer*" is label for empty row. The same bug in the latest WebKit. ''reported by Dmitry Baranovskiy at 2006-07-20'' (link to mail archives?)
** I can't currently reproduce this. (see [http://microformats.org/discuss/mail/microformats-discuss/2006-July/004913.html email]) --[[User:RyanKing|RyanKing]] 15:00, 24 Jul 2006 (PDT)
** I can't currently reproduce this. (see [http://microformats.org/discuss/mail/microformats-discuss/2006-July/004913.html email]) --[[User:RyanKing|RyanKing]] 15:00, 24 Jul 2006 (PDT)

Revision as of 14:56, 15 May 2009

Contents

hReview creator feedback

This page is for collecting bugs, suggested fixes, and feature requests for the hReview creator

Please list your name, and indicate which version (even just a date and time helps) of the creator that you are providing feedback on. Thanks!


Bug Reports

appendChildNodes(description_element, P({}, ABBR({'title' : rating, 'class' : 'rating'}, unescape(rating_stars)), ' ', escape_output(paras[0]))); 

to

appendChildNodes(description_element, P({}, ABBR({'title' : rating, 'class' : 'rating'}, unescape(rating_stars(rating))), ' ', escape_output(paras[0]))); 

The hReview creator doesn't work with IE6 (unknown version) on XP, IE7 (unknown version) on Vista or Safari (3.2.1 (5525.27.1)) on OS X. The "Code", "Compact Code" and "Preview" areas of the page are never updated. Not sure why due to the rather opaque javascript error messages in IE and Safari.

Error: pad is not defined
Source File: http://microformats.org/code/hreview/creator
Line: 230
      $('#review-date-day').val(pad(d.getDate()));
Error: format_dt is not defined
Source File: http://microformats.org/code/hreview/creator
Line: 92
      var dt = format_dt(review_date_year, review_date_month, review_date_day, review_date_hour, review_date_minute, timezone);

Suggested Tweaks and Fixes

Feature Requests


Related Pages

hreview-creator-issues was last modified: Wednesday, December 31st, 1969

Views