hreview-creator-issues - Revision history

Aaronpk: Replace with {{DISPLAYTITLE:}}

2020-07-18T16:27:54Z

Replace <entry-title> with {{DISPLAYTITLE:}}

← Older revision		Revision as of 16:27, 18 July 2020
Line 1:		Line 1:
	~~<entry-title>~~hReview creator issues~~</entry-title>~~		{{DISPLAYTITLE:hReview creator issues}}

	This page is for collecting bugs, suggested fixes, and issues with the [[hreview\|hReview]] [http://microformats.org/code/hreview/creator creator]		This page is for collecting bugs, suggested fixes, and issues with the [[hreview\|hReview]] [http://microformats.org/code/hreview/creator creator]

Skierpage: /* Bug Reports */ add some more

2011-05-21T02:23:11Z

Bug Reports: add some more

← Older revision		Revision as of 02:23, 21 May 2011
Line 6:		Line 6:

	== Bug Reports ==		== Bug Reports ==
	* ~~In Firefox 3.0.10~~, ~~Opera 9.64 build 5270 if there is an entry in both the description~~ and ~~rating fields the source of the function "rating_stars" is returned rather than the value of evaluating it~~. ~~A quick fix would be to update line 153 of hreview.html from~~:		* Please add years past 2008 to the review-date-year <select> drop-down, and for bonus points pre-select today's date. -- [[User:Skierpage\|skierpage]] 02:23, 21 May 2011 (UTC)

	~~<pre>~~appendChildNodes(description_element, P({}, ABBR({'title' : rating, 'class' : 'rating'}, unescape(rating_stars)), ' ', escape_output(paras[0]))); </pre>		* In Firefox 3.0.10 and Opera 9.64 build 5270, if there is an entry in both the description and rating fields then the source of the function "rating_stars" is returned rather than the value of evaluating it. A quick fix would be to update line 153 of hreview.html from:
			appendChildNodes(description_element, P({}, ABBR({'title' : rating, 'class' : 'rating'}, unescape(rating_stars)), ' ', escape_output(paras[0]))); </pre>

	to		to
			appendChildNodes(description_element, P({}, ABBR({'title' : rating, 'class' : 'rating'}, unescape(rating_stars(rating))), ' ', escape_output(paras[0])));
			** This rating_stars bug is also present in Firefox 4 (and variants like SeaMonkey 2.1) -- [[User:Skierpage\|skierpage]] 02:23, 21 May 2011 (UTC)

	~~<pre>appendChildNodes~~(~~description_element~~, P(~~{}, ABBR~~({'~~title~~' ~~: rating,~~ '~~class~~' : '~~rating~~'~~}, unescape(rating_stars~~(~~rating)~~)~~), ' '~~, ~~escape_output~~(~~paras[0]~~)))~~; </pre>~~		* Doesn't work in Rekonq (a WebKit-based browser) version 0.7.0 on KDE Development Platform 4.6.2. The "Code", "Compact Code" and "Preview" areas of the page are never updated. The Developer console contains the single error below -- [[User:Skierpage\|skierpage]] 02:23, 21 May 2011 (UTC)
			85 TypeError: Result of expression '$('#review-date-year')[0].options[$('#review-date-year')[0].selectedIndex]' [undefined] is not an object.

			* The hReview creator doesn't work with IE6 (unknown version) on XP, IE7 (unknown version) on Vista or Safari (3.2.1 (5525.27.1)) on OS X. The "Code", "Compact Code" and "Preview" areas of the page are never updated. Not sure why due to the rather opaque javascript error messages in IE and Safari.

	The hReview creator doesn't work with IE6 (unknown version) on XP, IE7 (unknown version) on Vista or Safari (3.2.1 (5525.27.1)) on OS X. The "Code", "Compact Code" and "Preview" areas of the page are never updated. Not sure why due to the rather opaque javascript error messages in IE and Safari.
	* word "date" in "review date" jumps on the next row and moves "reviewer" down in Safari (var. 2.0.4 (419.3)). It looks like "review" is label for date, "date" is label for text field and "reviewer*" is label for empty row. The same bug in the latest WebKit. ''reported by Dmitry Baranovskiy at 2006-07-20'' (link to mail archives?)		* word "date" in "review date" jumps on the next row and moves "reviewer" down in Safari (var. 2.0.4 (419.3)). It looks like "review" is label for date, "date" is label for text field and "reviewer*" is label for empty row. The same bug in the latest WebKit. ''reported by Dmitry Baranovskiy at 2006-07-20'' (link to mail archives?)
	** I can't currently reproduce this. (see [http://microformats.org/discuss/mail/microformats-discuss/2006-July/004913.html email]) --[[User:RyanKing\|RyanKing]] 15:00, 24 Jul 2006 (PDT)		** I can't currently reproduce this. (see [http://microformats.org/discuss/mail/microformats-discuss/2006-July/004913.html email]) --[[User:RyanKing\|RyanKing]] 15:00, 24 Jul 2006 (PDT)

Tantek: issues links

2009-07-04T22:13:57Z

issues links

← Older revision		Revision as of 22:13, 4 July 2009
Line 36:		Line 36:
	== Related Pages ==		== Related Pages ==
	* [[hreview \|hReview specification]]		* [[hreview \|hReview specification]]
			* [[hreview-issues]]
	* [[hreview-feedback\|hReview feedback]]		* [[hreview-feedback\|hReview feedback]]
	* [[hcard-creator-~~feedback\|hCard creator feedback~~]]		* [[hcard-creator-issues]]
	* [[hcalendar-creator-~~feedback\|hCalendar creator feedback~~]]		* [[hcalendar-creator-issues]]

Tantek: edited to be focused on issues

2009-07-04T22:08:40Z

edited to be focused on issues

← Older revision		Revision as of 22:08, 4 July 2009
Line 1:		Line 1:
	<h1>hReview creator ~~feedback~~</h1>		<entry-title>hReview creator issues</entry-title>

	This page is for collecting bugs, suggested fixes, and ~~feature requests for~~ the [[hreview\|hReview]] [http://microformats.org/code/hreview/creator creator]		This page is for collecting bugs, suggested fixes, and issues with the [[hreview\|hReview]] [http://microformats.org/code/hreview/creator creator]

	Please list your name, and indicate ''which'' version (even just a date and time helps) of the creator that you are providing feedback on. Thanks!		Please list your name, and indicate ''which'' version (even just a date and time helps) of the creator that you are providing feedback on. Thanks!


	== Bug Reports ==		== Bug Reports ==
Line 34:		Line 33:
	== Suggested Tweaks and Fixes ==		== Suggested Tweaks and Fixes ==
	* Should "photo" be inside an "item" as well as "fn" and "url"? ''reported by Dmitry Baranovskiy at 2006-07-20'' (link to mail archives?)		* Should "photo" be inside an "item" as well as "fn" and "url"? ''reported by Dmitry Baranovskiy at 2006-07-20'' (link to mail archives?)

	~~== Feature Requests ==~~
	* ...



	== Related Pages ==		== Related Pages ==

Tantek: hreview-creator-feedback moved to hreview-creator-issues: so far only issues have been reported, which is more important to focus and resolve anyway. more consistent with other implementation related pages.�

2009-07-04T22:07:45Z

hreview-creator-feedback moved to hreview-creator-issues: so far only issues have been reported, which is more important to focus and resolve anyway. more consistent with other implementation related pages.�

← Older revision	Revision as of 22:07, 4 July 2009
(No difference)

Ntoll: Added javascript bug report with suggested patch

2009-05-15T14:56:02Z

Added javascript bug report with suggested patch

← Older revision		Revision as of 14:56, 15 May 2009
Line 7:		Line 7:

	== Bug Reports ==		== Bug Reports ==
			* In Firefox 3.0.10, Opera 9.64 build 5270 if there is an entry in both the description and rating fields the source of the function "rating_stars" is returned rather than the value of evaluating it. A quick fix would be to update line 153 of hreview.html from:

			<pre>appendChildNodes(description_element, P({}, ABBR({'title' : rating, 'class' : 'rating'}, unescape(rating_stars)), ' ', escape_output(paras[0]))); </pre>

			to

			<pre>appendChildNodes(description_element, P({}, ABBR({'title' : rating, 'class' : 'rating'}, unescape(rating_stars(rating))), ' ', escape_output(paras[0]))); </pre>

			The hReview creator doesn't work with IE6 (unknown version) on XP, IE7 (unknown version) on Vista or Safari (3.2.1 (5525.27.1)) on OS X. The "Code", "Compact Code" and "Preview" areas of the page are never updated. Not sure why due to the rather opaque javascript error messages in IE and Safari.
	* word "date" in "review date" jumps on the next row and moves "reviewer" down in Safari (var. 2.0.4 (419.3)). It looks like "review" is label for date, "date" is label for text field and "reviewer*" is label for empty row. The same bug in the latest WebKit. ''reported by Dmitry Baranovskiy at 2006-07-20'' (link to mail archives?)		* word "date" in "review date" jumps on the next row and moves "reviewer" down in Safari (var. 2.0.4 (419.3)). It looks like "review" is label for date, "date" is label for text field and "reviewer*" is label for empty row. The same bug in the latest WebKit. ''reported by Dmitry Baranovskiy at 2006-07-20'' (link to mail archives?)
	** I can't currently reproduce this. (see [http://microformats.org/discuss/mail/microformats-discuss/2006-July/004913.html email]) --[[User:RyanKing\|RyanKing]] 15:00, 24 Jul 2006 (PDT)		** I can't currently reproduce this. (see [http://microformats.org/discuss/mail/microformats-discuss/2006-July/004913.html email]) --[[User:RyanKing\|RyanKing]] 15:00, 24 Jul 2006 (PDT)

Brian: Reverted edits by AllirIcpas (Talk) to last version by Tantek

2009-01-03T19:12:58Z

Reverted edits by AllirIcpas (Talk) to last version by Tantek

← Older revision		Revision as of 19:12, 3 January 2009
Line 1:		Line 1:
	~~boliricmo~~
	<h1>hReview creator feedback</h1>		<h1>hReview creator feedback</h1>

AllirIcpas: rolpaslirel

2009-01-03T10:56:50Z

rolpaslirel

← Older revision		Revision as of 10:56, 3 January 2009
Line 1:		Line 1:
			boliricmo
	<h1>hReview creator feedback</h1>		<h1>hReview creator feedback</h1>

Tantek: collected bug report from Twitter

2008-02-27T22:56:53Z

collected bug report from Twitter

← Older revision		Revision as of 22:56, 27 February 2008
Line 21:		Line 21:
	Line: 92		Line: 92
	var dt = format_dt(review_date_year, review_date_month, review_date_day, review_date_hour, review_date_minute, timezone);</pre>		var dt = format_dt(review_date_year, review_date_month, review_date_day, review_date_hour, review_date_minute, timezone);</pre>
			* http://twitter.com/fedmor/statuses/751276422 - hReview creator fails in Firefox

	== Suggested Tweaks and Fixes ==		== Suggested Tweaks and Fixes ==

TravisHardiman: added lines of code

2008-02-04T16:22:02Z

added lines of code

← Older revision		Revision as of 16:22, 4 February 2008
Line 14:		Line 14:
	<pre>Error: pad is not defined		<pre>Error: pad is not defined
	Source File: http://microformats.org/code/hreview/creator		Source File: http://microformats.org/code/hreview/creator
	Line: 230</pre>		Line: 230
			$('#review-date-day').val(pad(d.getDate()));</pre>
	* Also JavaScript error when page is submitted --[[User:TravisHardiman\|TravisHardiman]] 08:16, 4 Feb 2008 (PST)		* Also JavaScript error when page is submitted --[[User:TravisHardiman\|TravisHardiman]] 08:16, 4 Feb 2008 (PST)
	<pre>Error: format_dt is not defined		<pre>Error: format_dt is not defined
	Source File: http://microformats.org/code/hreview/creator		Source File: http://microformats.org/code/hreview/creator
	Line: 92</pre>		Line: 92
			var dt = format_dt(review_date_year, review_date_month, review_date_day, review_date_hour, review_date_minute, timezone);</pre>

	== Suggested Tweaks and Fixes ==		== Suggested Tweaks and Fixes ==