hReview creator issues
Jump to navigation
Jump to search
This page is for collecting bugs, suggested fixes, and issues with the hReview creator
Please list your name, and indicate which version (even just a date and time helps) of the creator that you are providing feedback on. Thanks!
Bug Reports
- Please add years past 2008 to the review-date-year <select> drop-down, and for bonus points pre-select today's date. -- skierpage 02:23, 21 May 2011 (UTC)
- In Firefox 3.0.10 and Opera 9.64 build 5270, if there is an entry in both the description and rating fields then the source of the function "rating_stars" is returned rather than the value of evaluating it. A quick fix would be to update line 153 of hreview.html from:
appendChildNodes(description_element, P({}, ABBR({'title' : rating, 'class' : 'rating'}, unescape(rating_stars)), ' ', escape_output(paras[0])));
to
appendChildNodes(description_element, P({}, ABBR({'title' : rating, 'class' : 'rating'}, unescape(rating_stars(rating))), ' ', escape_output(paras[0])));
- This rating_stars bug is also present in Firefox 4 (and variants like SeaMonkey 2.1) -- skierpage 02:23, 21 May 2011 (UTC)
- Doesn't work in Rekonq (a WebKit-based browser) version 0.7.0 on KDE Development Platform 4.6.2. The "Code", "Compact Code" and "Preview" areas of the page are never updated. The Developer console contains the single error below -- skierpage 02:23, 21 May 2011 (UTC)
85 TypeError: Result of expression '$('#review-date-year')[0].options[$('#review-date-year')[0].selectedIndex]' [undefined] is not an object.
- The hReview creator doesn't work with IE6 (unknown version) on XP, IE7 (unknown version) on Vista or Safari (3.2.1 (5525.27.1)) on OS X. The "Code", "Compact Code" and "Preview" areas of the page are never updated. Not sure why due to the rather opaque javascript error messages in IE and Safari.
- word "date*" in "review date*" jumps on the next row and moves "reviewer*" down in Safari (var. 2.0.4 (419.3)). It looks like "review" is label for date, "date*" is label for text field and "reviewer*" is label for empty row. The same bug in the latest WebKit. reported by Dmitry Baranovskiy at 2006-07-20 (link to mail archives?)
- I didn't noticed value of url field in generated code. reported by Dmitry Baranovskiy at 2006-07-20 (link to mail archives?)
- JavaScript error in Firefox 2.0.0.11 in XP on page load --TravisHardiman 08:16, 4 Feb 2008 (PST)
Error: pad is not defined
Source File: http://microformats.org/code/hreview/creator
Line: 230
$('#review-date-day').val(pad(d.getDate()));
- Also JavaScript error when page is submitted --TravisHardiman 08:16, 4 Feb 2008 (PST)
Error: format_dt is not defined
Source File: http://microformats.org/code/hreview/creator
Line: 92
var dt = format_dt(review_date_year, review_date_month, review_date_day, review_date_hour, review_date_minute, timezone);
- http://twitter.com/fedmor/statuses/751276422 - hReview creator fails in Firefox
Suggested Tweaks and Fixes
- Should "photo" be inside an "item" as well as "fn" and "url"? reported by Dmitry Baranovskiy at 2006-07-20 (link to mail archives?)